Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firestore): use internal/detect #10561

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

jba
Copy link
Contributor

@jba jba commented Jul 17, 2024

No description provided.

@jba jba requested review from a team as code owners July 17, 2024 23:52
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jul 17, 2024
@jba jba force-pushed the jba/firestore-detect branch from fc955fa to 3647281 Compare July 18, 2024 10:55
@codyoss
Copy link
Member

codyoss commented Dec 10, 2024

@jba it looks like the test here are failing. Is this change still wanted?

@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 10, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 798c7e6 into main Dec 10, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the jba/firestore-detect branch December 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants