Update nodejs demos #47
Conversation
| compute = new googleapis.auth.Compute(), | ||
| datastore = null, | ||
| todoListName = null; | ||
| var googleapis = require('googleapis'); |
There was a problem hiding this comment.
why did you remove the 1 line var construct?
There was a problem hiding this comment.
If each thing is being assigned something, I like to use a separate var for each assignment. Makes deletions and insertions in the future easier to follow in diffs as well.
|
/cc @pcostell |
| @@ -19,11 +19,11 @@ var util = require('util'); | |||
| var events = require('events'); | |||
| var readline = require('readline'); | |||
| var googleapis = require('googleapis'); | |||
| var datastore = googleapis.datastore('v1'); | |||
There was a problem hiding this comment.
Our latest version is v1beta2.
There was a problem hiding this comment.
Oh, okay. v1 suggests it's done and beta2 suggests it's not done, so I assumed v1 was more up to date. My apologies.
There was a problem hiding this comment.
AFAIK, there is no v1 version published for the datastore API. The _v1 suffix of the proto file refers to something else :)
There was a problem hiding this comment.
You're correct. Not sure where I got v1 from but you're probably on the right track with _v1 suffix lol. Thanks :)
|
Fixed the datastore version to v1beta2. |
|
A little confused what the question is -- featuring where? @proppy |
|
@jgeewax is this repo, in our docs, etc. |
|
What's the status of this PR? Merging? |
|
@rakyll blocked on googleapis/google-api-nodejs-client#278 ? |
|
Not really. It's just a nice to have. |
|
Closing in favour of using gcloud-node instead. |
I've taken the liberty of trying to update the nodejs demos in this repo to work with the new google-api-nodejs-client. I haven't actually tested the changes so if someone could give this a second look & perhaps test it, that'd be awesome.
Plus general feedback is always welcome. Maybe we want to scrap this altogether and create a better demo?