Skip to content

Revert "chore(deps): update dependency com_github_grpc_grpc to v1.38.1"#6841

Merged
devjgm merged 1 commit intomainfrom
revert-6826-renovate/com_github_grpc_grpc-1.x
Jun 22, 2021
Merged

Revert "chore(deps): update dependency com_github_grpc_grpc to v1.38.1"#6841
devjgm merged 1 commit intomainfrom
revert-6826-renovate/com_github_grpc_grpc-1.x

Conversation

@devjgm
Copy link
Copy Markdown
Contributor

@devjgm devjgm commented Jun 22, 2021

Reverts #6826

Rolling this back because grpc 1.38.1 breaks our builds that use pkg-config. See also #6840


This change is Reviewable

@devjgm devjgm requested a review from a team June 22, 2021 18:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 34388e6dd2c1584e644c03e23e575368a0d9ac29

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 22, 2021

Codecov Report

Merging #6841 (34388e6) into main (c0be918) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6841      +/-   ##
==========================================
- Coverage   95.04%   95.04%   -0.01%     
==========================================
  Files        1264     1264              
  Lines      113312   113312              
==========================================
- Hits       107694   107693       -1     
- Misses       5618     5619       +1     
Impacted Files Coverage Δ
google/cloud/spanner/internal/spanner_stub.cc 76.41% <0.00%> (-0.95%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 81.41% <0.00%> (+0.44%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0be918...34388e6. Read the comment docs.

@devjgm devjgm merged commit 7b1ecd7 into main Jun 22, 2021
@devjgm devjgm deleted the revert-6826-renovate/com_github_grpc_grpc-1.x branch June 22, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants