impl(spanner): do Uuid to/from string conversions using absl::uint128 #15057
+126
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of processing the high and low 64 bits of the Uuid separately, just use the 128-bit value directly. Also simplify the Uuid tests. Fixes googleapis#15043.
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15057 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 2354 2354
Lines 210374 210366 -8
=======================================
+ Hits 195443 195449 +6
+ Misses 14931 14917 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It looks like the cmake-oldest-deps build is old enough to not support the deduced-type `%v` specifier.
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of processing the high and low 64 bits of the Uuid separately, just use the 128-bit value directly.
Also simplify the Uuid tests.
Fixes #15043.
This change is