Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mTLS REST prototype #15054

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Mar 26, 2025

This change is Reviewable

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 47.91667% with 125 lines in your changes missing coverage. Please review.

Project coverage is 92.85%. Comparing base (97d29c3) to head (a173342).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...e/tests/mtls_object_basic_crud_integration_test.cc 6.52% 86 Missing ⚠️
google/cloud/internal/curl_impl.cc 17.39% 19 Missing ⚠️
google/cloud/internal/unified_rest_credentials.cc 0.00% 9 Missing ⚠️
google/cloud/internal/unified_grpc_credentials.cc 0.00% 5 Missing ⚠️
...cloud/storage/internal/unified_rest_credentials.cc 0.00% 3 Missing ⚠️
google/cloud/internal/oauth2_mtls_credentials.h 50.00% 2 Missing ⚠️
google/cloud/mtls_credentials_config.cc 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15054      +/-   ##
==========================================
- Coverage   92.90%   92.85%   -0.05%     
==========================================
  Files        2351     2357       +6     
  Lines      210211   210451     +240     
==========================================
+ Hits       195296   195414     +118     
- Misses      14915    15037     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant