Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more cases for generating new libraries #14806

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Oct 25, 2024

  1. Added one more case when we need to update the googleapis SHA.

  2. Added a description of the error we expected when running check-api-pr

  3. Replace bazel with bazelisk in case the lastest bazel version is not available via apt get install.


This change is Reviewable

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (bf3bf1c) to head (f9d5aad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14806      +/-   ##
==========================================
- Coverage   93.27%   93.27%   -0.01%     
==========================================
  Files        2319     2319              
  Lines      208231   208231              
==========================================
- Hits       194237   194227      -10     
- Misses      13994    14004      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 marked this pull request as ready for review October 28, 2024 15:01
@cuiy0006 cuiy0006 requested a review from a team as a code owner October 28, 2024 15:01
@cuiy0006 cuiy0006 enabled auto-merge (squash) October 28, 2024 15:37
@cuiy0006 cuiy0006 merged commit 852cff0 into googleapis:main Oct 28, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants