Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable layering check in bazel #14721

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 19, 2024

Part of the work for #12760

Note that changes in the .bazelrc only affect our WORKSPACE. Downstream applications cannot be affected.


This change is Reviewable

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (fbc2aa6) to head (525daad).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14721      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files        2323     2323              
  Lines      207947   207947              
==========================================
- Hits       194440   194438       -2     
- Misses      13507    13509       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review September 19, 2024 20:59
@dbolduc dbolduc requested a review from a team as a code owner September 19, 2024 20:59
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 39a3faf into googleapis:main Sep 20, 2024
72 checks passed
@dbolduc dbolduc deleted the layering-check-bazel branch September 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants