cleanup(quickstart): gkeconnect quickstart use correct inputs #14666
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14666 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 2316 2316
Lines 207140 207140
==========================================
- Hits 193868 193864 -4
- Misses 13272 13276 +4 ☔ View full report in Codecov by Sentry. |
| @@ -14,21 +14,27 @@ | |||
|
|
|||
| //! [all] | |||
| #include "google/cloud/gkeconnect/gateway/v1/gateway_control_client.h" | |||
| #include "google/cloud/internal/absl_str_cat_quiet.h" | |||
There was a problem hiding this comment.
We don't want customers including internal headers in their applications, so we shouldn't include internal headers in our examples/quickstarts.
There was a problem hiding this comment.
It is interesting, I am using #include "absl/strings/str_cat.h", it is automatically replaced by checkers-pr.
There was a problem hiding this comment.
https://screenshot.googleplex.com/AVbJ46XqY6yxaPG
Does that mean we can't use absl::StrCat in quickstart code?
I can replace it with plain string addition.
There was a problem hiding this comment.
Yeah. I think we tend to do string addition in these.
Make gkeconnect quickstart use correct inputs.
name=projects/*/locations/*/memberships/*This change is