-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use self-signed jwt for service account #665
Merged
+373
−38
Merged
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
17b72e1
feat: use self-signed jwt for service account
busunkim96 891ea31
chore: remove docs changes
busunkim96 12a7437
fix: fix for 2.7
busunkim96 2db9b5b
Merge branch 'master' into self-signed-jwt
busunkim96 dd0c6f3
fix: use 'default_host' instead of 'audience'
busunkim96 a5a72b5
Merge branch 'self-signed-jwt' of github.com:googleapis/google-auth-l…
busunkim96 ed68dc5
fix: audience ends with trailing slash
busunkim96 e425e81
test: run system tests
busunkim96 1fb684c
test: decrypt secrets
busunkim96 4a52bd2
test: add secrets tar
busunkim96 6a556ca
test: more fixes to config
busunkim96 f3399d7
test: fix gfile_resources in presubmit config
busunkim96 96915f9
test: project-id.txt
busunkim96 d46592e
chore: properly exclude config files in synth
busunkim96 98d3a43
test: fix conftest, async tests
busunkim96 59c4416
test: update secrets, import mock
busunkim96 b7adf59
test: fix more system tests
busunkim96 7bfbd9f
Merge branch 'master' into self-signed-jwt
busunkim96 5be177f
Merge branch 'master' into self-signed-jwt
busunkim96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding an additional optional parameter to an abstract method a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fine.
https://stackoverflow.com/questions/42778784/abstract-classes-with-varying-amounts-of-parameters