feat: Add retry logic when certificate mismatch for existing credentials & Agent Identity workloads #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawalradhika-cell
changed the title
Contributor
|
Is the description accurate? This will apply to existing X509 workloads too? |
agrawalradhika-cell
changed the title
Contributor
Author
Updated the description |
nbayati
reviewed
Oct 22, 2025
nbayati
requested changes
Oct 24, 2025
| @@ -0,0 +1,188 @@ | |||
| # Copyright 2025 Google LLC | |||
Contributor
There was a problem hiding this comment.
Leaving a comment here so we won't forget to wait for the PR #1821 to merge first and do a rebase to ensure we don't have duplicated or conflicting code.
nbayati
added
the
do not merge
sai-sunder-s
previously approved these changes
Oct 30, 2025
Collaborator
|
My main points are to add the The main blocker left is getting the tests to pass |
This change introduces retry support when requests are created for AgentIdentities on GKE and Cloud Run Workloads. Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
…ion and request Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
… from mTLS configuration Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
… and fix the test mock Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
nbayati
force-pushed
the
cert-rotation-x509
branch
from
09e13e4 to
22658a4
Compare
nbayati
removed
the
do not merge
nbayati
approved these changes
Dec 15, 2025
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
approved these changes
Dec 15, 2025
daniel-sanche
merged commit 8a9cb7b
into
googleapis:agent_identity_staging
5 checks passed
daniel-sanche
added a commit
that referenced
this pull request
Dec 15, 2025
…ate mismatches with retries (#1890) This PR includes adding changes which are for - - Adding support for Agent Identity bound tokens which will be used for Agent Identity (#1821) - Adding the retry logic when certificates mismatch for credentials used for Agent Identities on GKE and Cloud Run Workloads. (#1841) --------- Signed-off-by: Radhika Agrawal <agrawalradhika@google.com> Co-authored-by: nbayati <99771966+nbayati@users.noreply.github.com> Co-authored-by: Andy Zhao <andyzhao@google.com> Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add retry logic when certificate mismatch for existing credentials & Agent Identity workloads
This change introduces retry support when requests are created for existing credentials and Agent Identities on GKE and Cloud Run Workloads. When 401(Unauthorized) error is created, due to certificate at time of configuration of mTLS channel being different from the current certificate, a retry is added to the request by configuring the mTLS channel with the current certificate.