Fix lint #37
Merged
Fix lint #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
busunkim96
commented
Mar 22, 2019
| @@ -26,6 +26,8 @@ | |||
| 'redefined-variable-type', | |||
| 'similarities', | |||
| 'no-else-return', | |||
| 'useless-object-inheritance', | |||
| "wrong-import-order", # checked with flake8 | |||
There was a problem hiding this comment.
Flake8 is already checking the import order, and this is causing lint errors.
JustinBeckwith
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint tests passed when they were run ~1 year ago, and failed when they were run more recently.