This repository was archived by the owner on Nov 20, 2025. It is now read-only.
feat: adds suppliers for custom subject token and AWS credentials #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: refactor aws and identity pool credentials to use suppliers * Apply suggestions from code review Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Daniel Bankhead <dan@danielbankhead.com> * updating suppliers to use options objects * updating docs * moved transporter to context object and deprecated consts * fix imports --------- Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
…h custom suppliers. (#1783) * feat: adds support for users to build credentials with custom suppliers Also adds default values to make it easier to instantiate credentials in code. * Apply suggestions from code review Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> * responding to review comments --------- Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
* docs: adding documentation for programmatic auth feature * fix typos * Apply suggestions from code review Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> Co-authored-by: Daniel Bankhead <dan@danielbankhead.com> * add audience placeholder --------- Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com> Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
# Conflicts: # src/auth/awsclient.ts # src/auth/identitypoolclient.ts
|
Warning: This pull request is touching the following templated files:
|
lsirac
approved these changes
Apr 16, 2024
danielbankhead
approved these changes
Apr 17, 2024
Contributor
danielbankhead
left a comment
danielbankhead
left a comment
There was a problem hiding this comment.
Lgtm; one lint warning
This was referenced Jun 7, 2024
This was referenced Jun 14, 2024
This was referenced Sep 26, 2024
This was referenced Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.