ruby 2.7.1 deprecation warnings

[josh-m-sharpe]

It seems that creating a request object in this manner results in deprecation warnings stemming from ruby 2.7.1. This rails issue seems related: rails/rails#38202

I didn't see an issue anywhere that was tracking these deprecations. Apologies if this is already tracked.

request = Google::Apis::SheetsV4::BatchUpdateSpreadsheetRequest.new({
  requests: [{
    add_sheet: Google::Apis::SheetsV4::AddSheetRequest.new({
      properties: Google::Apis::SheetsV4::SheetProperties.new({
        title: "Some Title"
      })
    })
  }]
})

response = client.batch_update_spreadsheet(SPREADSHEET_ID, request)

(irb):67: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/me/.rvm/gems/ruby-2.7.1/gems/google-api-client-0.41.2/generated/google/apis/sheets_v4/classes.rb:8979: warning: The called method `initialize' is defined here
(irb):66: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/me/.rvm/gems/ruby-2.7.1/gems/google-api-client-0.41.2/generated/google/apis/sheets_v4/classes.rb:311: warning: The called method `initialize' is defined here
(irb):64: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/me/.rvm/gems/ruby-2.7.1/gems/google-api-client-0.41.2/generated/google/apis/sheets_v4/classes.rb:2014: warning: The called method `initialize' is defined here```

[dazuma]

Need to update the generator templates.

[stanhu]

Note that these deprecation warnings are now hard failures in Ruby v3.0.

[dazuma]

I was looking at this now. The usage provided in the original report is incorrect. Arguments to object constructors are keyword arguments, not hashes.

Instead of:

request = Google::Apis::SheetsV4::BatchUpdateSpreadsheetRequest.new({
  requests: [{
    add_sheet: Google::Apis::SheetsV4::AddSheetRequest.new({
      properties: Google::Apis::SheetsV4::SheetProperties.new({
        title: "Some Title"
      })
    })
  }]
})

response = client.batch_update_spreadsheet(SPREADSHEET_ID, request)

Please use:

request = Google::Apis::SheetsV4::BatchUpdateSpreadsheetRequest.new(
  requests: [{
    add_sheet: Google::Apis::SheetsV4::AddSheetRequest.new(
      properties: Google::Apis::SheetsV4::SheetProperties.new(
        title: "Some Title"
      )
    )
  }]
)

response = client.batch_update_spreadsheet(SPREADSHEET_ID, request)

Closing this as working as intended. Please fix your calling code. If you got your current usage from some documentation or samples, it's possible those need to be corrected as well. (I checked the documentation in this repo, and didn't see any problems, but let me know if I missed something.)