Release v1.5.4 #294
Merged
Release v1.5.4 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Am I reading the test results correctly as indicating that we're not yet compatible with |
|
@nathanielmanistaatgoogle apparently not! :D I'll have to revisit this later. |
|
Understood; thanks. |
theacodes
force-pushed
the
release-v1.5.4
branch
from
c53b0f1 to
a9627e7
Compare
|
@nathanielmanistaatgoogle this is fixed now and should be good to merge. The only tricky bit is that file_cache depended on locked_file, which we removed. The cache stuff was already well-guarded against failure, but the tests were not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.