Skip to content

Conversation

@theacodes
Copy link
Contributor

@tmatsuo
Copy link
Contributor

tmatsuo commented Feb 20, 2016

LGTM except for one comment

@theacodes
Copy link
Contributor Author

This commit looks behaviorally interesting and non-trivial

A few things:

  • It's pretty trivial. There are some APIs that are returned by the discovery endpoint that do not yet have published discovery docs. This will try to build those APIs anyway and explode. The APIs that cause this aren't public yet and therefore should not be part of the public documentation.
  • It does not change behavior; if anything, it ensures that the current behavior is maintained despite a change in expectations from the discovery service.
  • This change is in our docs building tool and not the library itself.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2016
@theacodes
Copy link
Contributor Author

Please maintain no-blank-line-between-doc-string-and-behavior-body in this codebase?

Fixed.

@nathanielmanistaatgoogle
Copy link
Contributor

Looks good and thanks for the release. :-)

@theacodes
Copy link
Contributor Author

Thanks, @nathanielmanistaatgoogle. :)

theacodes pushed a commit that referenced this pull request Feb 20, 2016
@theacodes theacodes merged commit e2fd7cb into master Feb 20, 2016
@theacodes theacodes deleted the release-v1.5.0 branch February 20, 2016 01:23
@theacodes
Copy link
Contributor Author

Published to PyPI. #190 has been opened to both automate and document this process in the future.

akrherz pushed a commit to akrherz/google-api-python-client that referenced this pull request Apr 1, 2019
Fixes intermittent EAGAIN failures in devshell tests (googleapis#188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants