-
Notifications
You must be signed in to change notification settings - Fork 2k
build: resolve update-api workflow failure #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+93
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
reviewed
Sep 11, 2025
miguelvelezsa
previously approved these changes
Sep 17, 2025
miguelvelezsa
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The generation of versionName in the download.ts file results in the incorrect generation of files, leading to "ENOENT: no such file or directory" errors during the synth script execution.
Impact
This change should prevent the failure in question and catch any breaking changes that may cause it in the future.
In particular, it fixes: https://github.com/googleapis/google-api-nodejs-client/actions/runs/17559322736/job/49873442821
Testing
A unit test was added.
Additional Information
Slight refactoring to improve readability.