Skip to content

Conversation

GautamSharda
Copy link
Collaborator

Description

The generation of versionName in the download.ts file results in the incorrect generation of files, leading to "ENOENT: no such file or directory" errors during the synth script execution.

Impact

This change should prevent the failure in question and catch any breaking changes that may cause it in the future.

In particular, it fixes: https://github.com/googleapis/google-api-nodejs-client/actions/runs/17559322736/job/49873442821

Testing

A unit test was added.

Additional Information

Slight refactoring to improve readability.

@GautamSharda GautamSharda requested a review from a team as a code owner September 11, 2025 00:59
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 11, 2025
@leahecole leahecole changed the title Fix update-api workflow failure fix: resolve update-api workflow failure Sep 11, 2025
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2025
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2025
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 11, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 15, 2025
@GautamSharda GautamSharda added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 15, 2025
@GautamSharda GautamSharda added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2025
@GautamSharda GautamSharda added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2025
@GautamSharda GautamSharda added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2025
@sofisl sofisl changed the title fix: resolve update-api workflow failure build: resolve update-api workflow failure Sep 16, 2025
miguelvelezsa
miguelvelezsa previously approved these changes Sep 17, 2025
@miguelvelezsa miguelvelezsa self-requested a review September 17, 2025 21:17
@GautamSharda GautamSharda added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2025
@sofisl sofisl added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2025
@GautamSharda GautamSharda merged commit 96f9e8b into googleapis:main Sep 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants