refactor: use local-auth for 3 legged samples#2058
Merged
JustinBeckwith merged 2 commits intomasterfrom Apr 27, 2020
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
=======================================
Coverage 38.91% 38.91%
=======================================
Files 6 6
Lines 1074 1074
Branches 8 8
=======================================
Hits 418 418
Misses 656 656 Continue to review full report at Codecov.
|
bcoe
approved these changes
Apr 27, 2020
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
this is delightful, I think it demonstrates that this is the right refactor that we're deleting 200 lines of code.
alexander-fenster
approved these changes
Apr 27, 2020
JustinBeckwith
force-pushed
the
localauth
branch
from
64c212f to
b48eb5e
Compare
JustinBeckwith
added
automerge
googlebot
added
the
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.