Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: update system test to use monorepo where appropriate#1387

Merged
leahecole merged 2 commits intogoogleapis:mainfrom
leahecole:fix_1385
Dec 7, 2022
Merged

fix: update system test to use monorepo where appropriate#1387
leahecole merged 2 commits intogoogleapis:mainfrom
leahecole:fix_1385

Conversation

@leahecole
Copy link
Collaborator

@leahecole leahecole commented Dec 7, 2022

Fixes the system test to pull from the monorepo for video intelligence and kms, and to pull from the speech repo for speech. It's a little gross because we now have some monorepo tests and some not, but it's nothing some good ol' ternary operators can't handle!

Remove videointelligence because it's flaky and the smoke test was removed recently anyways, so it would have been doing nothing once the latest release came out

this is my first typescript PR (back in 2019 I was still doing regular node when I was contributing code) so be ruthless and teach me the ways! 😁

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) (not relevant)

Fixes googleapis/google-cloud-node-core#273

@leahecole leahecole requested review from a team as code owners December 7, 2022 16:09
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 7, 2022
@leahecole leahecole marked this pull request as draft December 7, 2022 16:26
@leahecole
Copy link
Collaborator Author

I'm unable to replicate this timeout failure locally or in the videointelligence repo but I'm requesting a rebuild to see if it's a flake

@leahecole leahecole marked this pull request as ready for review December 7, 2022 18:13
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@leahecole
Copy link
Collaborator Author

Update, I am able to make this failure occur locally when I checkout the v4.1.1 version of video intelligence. Fwiw, I noticed that this PR gets rid of the smoke tests used here googleapis/google-cloud-node@6c68bd8

Not sure if we want to keep using video intelligence given that?

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@leahecole leahecole merged commit 3717cd2 into googleapis:main Dec 7, 2022
@leahecole leahecole deleted the fix_1385 branch April 4, 2024 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update system tests to pull from correct repo location

3 participants