This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: update system test to use monorepo where appropriate#1387
Merged
leahecole merged 2 commits intogoogleapis:mainfrom Dec 7, 2022
Merged
fix: update system test to use monorepo where appropriate#1387leahecole merged 2 commits intogoogleapis:mainfrom
leahecole merged 2 commits intogoogleapis:mainfrom
Conversation
Collaborator
Author
|
I'm unable to replicate this timeout failure locally or in the videointelligence repo but I'm requesting a rebuild to see if it's a flake |
Collaborator
Author
|
Update, I am able to make this failure occur locally when I checkout the v4.1.1 version of video intelligence. Fwiw, I noticed that this PR gets rid of the smoke tests used here googleapis/google-cloud-node@6c68bd8 Not sure if we want to keep using video intelligence given that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the system test to pull from the monorepo for
video intelligence andkms, and to pull from the speech repo for speech. It's a little gross because we now have some monorepo tests and some not, but it's nothing some good ol' ternary operators can't handle!Remove videointelligence because it's flaky and the smoke test was removed recently anyways, so it would have been doing nothing once the latest release came out
this is my first typescript PR (back in 2019 I was still doing regular node when I was contributing code) so be ruthless and teach me the ways! 😁
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis/google-cloud-node-core#273