Skip to content

Commit

Permalink
incorporate review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
kevkim-codes committed Oct 3, 2024
1 parent 88d433f commit 80f5f5c
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions gax/test/unit/streaming.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,7 @@ describe('streaming', () => {
});
});

it.only('properly emits the end event at the end of a pipeline transformation', done => {
it('properly emits the end event at the end of a pipeline transformation', done => {
const spy = sinon.spy((...args: Array<{}>) => {
assert.strictEqual(args.length, 3);
const s = new PassThrough({
Expand All @@ -1494,7 +1494,7 @@ describe('streaming', () => {
});

// Initial stream.
const apiCall = createApiCallStreaming(
const apiCall = createApiCallStreaming(
spy,
streaming.StreamType.SERVER_STREAMING,
false,
Expand All @@ -1520,14 +1520,6 @@ describe('streaming', () => {

const finalResults: Array<{resources: Array<number>}> = [];

s1.on('error', (err: GoogleError) => {
console.log('s1 error');
done(err);
});

s2.on('error', (err: GoogleError) => {
done(err);
});
s2.on('data', data => {
finalResults.push(data);
});
Expand Down

0 comments on commit 80f5f5c

Please sign in to comment.