Skip to content

Commit

Permalink
Merge branch 'main' into gax4upgrade-2
Browse files Browse the repository at this point in the history
  • Loading branch information
leahecole authored Aug 22, 2023
2 parents ecfb2f7 + b322f78 commit 783e736
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 17 deletions.
2 changes: 1 addition & 1 deletion src/apitypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export type RawResponseType = Operation | {} | null;
export type ResultTuple = [
ResponseType | [ResponseType],
NextPageRequestType | undefined,
RawResponseType | undefined
RawResponseType | undefined,
];

export interface SimpleCallbackFunction {
Expand Down
6 changes: 3 additions & 3 deletions src/clientInterface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export interface Descriptors {
export interface Callback<
ResponseObject,
NextRequestObject,
RawResponseObject
RawResponseObject,
> {
(
err: Error | null | undefined,
Expand All @@ -70,7 +70,7 @@ export interface LROperation<ResultType, MetadataType>
export interface PaginationCallback<
RequestObject,
ResponseObject,
ResponseType
ResponseType,
> {
(
err: Error | null,
Expand All @@ -83,7 +83,7 @@ export interface PaginationCallback<
export interface PaginationResponse<
RequestObject,
ResponseObject,
ResponseType
ResponseType,
> {
values?: ResponseType[];
nextPageRequest?: RequestObject;
Expand Down
4 changes: 2 additions & 2 deletions src/locationService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export class LocationsClient {
[
protos.google.cloud.location.ILocation[],
protos.google.cloud.location.IListLocationsRequest | null,
protos.google.cloud.location.IListLocationsResponse
protos.google.cloud.location.IListLocationsResponse,
]
>;
listLocations(
Expand Down Expand Up @@ -438,7 +438,7 @@ export class LocationsClient {
[
protos.google.cloud.location.ILocation[],
protos.google.cloud.location.IListLocationsRequest | null,
protos.google.cloud.location.IListLocationsResponse
protos.google.cloud.location.IListLocationsResponse,
]
> | void {
request = request || {};
Expand Down
16 changes: 8 additions & 8 deletions test/showcase-echo-client/src/v1beta1/echo_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IEchoResponse,
protos.google.showcase.v1beta1.IEchoRequest | undefined,
{} | undefined
{} | undefined,
]
>;
echo(
Expand Down Expand Up @@ -558,7 +558,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IEchoResponse,
protos.google.showcase.v1beta1.IEchoRequest | undefined,
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -798,7 +798,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IBlockResponse,
protos.google.showcase.v1beta1.IBlockRequest | undefined,
{} | undefined
{} | undefined,
]
>;
block(
Expand Down Expand Up @@ -836,7 +836,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IBlockResponse,
protos.google.showcase.v1beta1.IBlockRequest | undefined,
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -996,7 +996,7 @@ export class EchoClient {
protos.google.showcase.v1beta1.IWaitMetadata
>,
protos.google.longrunning.IOperation | undefined,
{} | undefined
{} | undefined,
]
>;
wait(
Expand Down Expand Up @@ -1049,7 +1049,7 @@ export class EchoClient {
protos.google.showcase.v1beta1.IWaitMetadata
>,
protos.google.longrunning.IOperation | undefined,
{} | undefined
{} | undefined,
]
> | void {
request = request || {};
Expand Down Expand Up @@ -1131,7 +1131,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IEchoResponse[],
protos.google.showcase.v1beta1.IPagedExpandRequest | null,
protos.google.showcase.v1beta1.IPagedExpandResponse
protos.google.showcase.v1beta1.IPagedExpandResponse,
]
>;
pagedExpand(
Expand Down Expand Up @@ -1171,7 +1171,7 @@ export class EchoClient {
[
protos.google.showcase.v1beta1.IEchoResponse[],
protos.google.showcase.v1beta1.IPagedExpandRequest | null,
protos.google.showcase.v1beta1.IPagedExpandResponse
protos.google.showcase.v1beta1.IPagedExpandResponse,
]
> | void {
request = request || {};
Expand Down
1 change: 0 additions & 1 deletion test/test-application/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ async function testShowcase() {
};

const grpcClient = new EchoClient(grpcClientOpts);

const grpcClientWithNewRetry = new EchoClient(grpcClientOptsWithNewRetry);
const grpcSequenceClientWithNewRetry = new SequenceServiceClient(
grpcClientOptsWithNewRetry
Expand Down
4 changes: 2 additions & 2 deletions test/unit/longrunning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,11 @@ describe('longrunning', () => {
const client = mockOperationsClient({expectedCalls: 0});
const apiCall = createApiCall(func, client);
const [operation] = (await apiCall({})) as unknown as [
longrunning.Operation
longrunning.Operation,
];
assert.notStrictEqual(operation, null);
const [finalResult] = (await operation!.promise()) as unknown as [
string
string,
];
assert.strictEqual(finalResult, RESPONSE_VAL);
});
Expand Down

0 comments on commit 783e736

Please sign in to comment.