build: refactor Gradle build #1539
Conversation
chanseokoh
commented
Oct 18, 2021
chanseokoh
commented
- Separating Gradle configurations for releasable projects vs. non-releasable projects.
- Separating Gradle configurations for Java projects vs. non-Java projects ('gax-bom').
- Auto-detect publishing to local and skip signing.
- Miscellaneous cleanups.
google-cla
bot
added
the
cla: yes
| } | ||
|
|
||
| if (project.hasProperty('ossrhUsername') && project.hasProperty('ossrhPassword') && | ||
| !nonReleaseProjects.contains(project.name)) { |
There was a problem hiding this comment.
This doesn't make sense. As this is the root build.gradle, project.name is always gax-java. And it's correct to configure nexusPublishing in the root.
| artifactId = project.name | ||
| description = 'Google Api eXtensions for Java' | ||
| url = 'https://github.com/googleapis/gax-java' | ||
| publishing { |
There was a problem hiding this comment.
No changes to the inside block of if (!noDefaultPublications.contains(project.name)) { except one change that I commented below.
| } | ||
| sign publishing.publications.mavenJava | ||
| signing { | ||
| required { gradle.taskGraph.hasTask ":${name}:publishToSonatype" } |
There was a problem hiding this comment.
Added required {. And we already filtered noDefaultPublications.
| @@ -36,66 +37,46 @@ tasks.whenTaskAdded { task -> | |||
| } | |||
| } | |||
|
|
|||
| jar.enabled = false | |||
There was a problem hiding this comment.
Not applying java-library anymore, so we can remove everything related to Java.
chanseokoh
force-pushed
the
refactor-gradle
branch
from
baca85a to
e9fa081
Compare
chanseokoh
force-pushed
the
refactor-gradle
branch
from
f20744f to
df90bc1
Compare
|
Fixed a build failure. Ready for review. |
| @@ -37,46 +37,45 @@ tasks.whenTaskAdded { task -> | |||
| } | |||
| } | |||
|
|
|||
| afterEvaluate { | |||
There was a problem hiding this comment.
Don't we need this anymore?
There was a problem hiding this comment.
We don't. Now everything inside the block is usable and available. We don't need to wait until the project is evaluated.
