-
Notifications
You must be signed in to change notification settings - Fork 130
chore: update showcase version for sequence tests #3268
chore: update showcase version for sequence tests #3268
Conversation
3594e1c
to
4cde440
Compare
I'm not really sure why the ruby tests are failing with Not really sure what to do about that. We've migrated everything to gapic-generator-ruby, maybe we shouldn't make the tests required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a a few minor comments.
Let's ask @viacheslav-rostovtsev he things about ruby failures?
showcase/java/src/test/java/com/google/api/showcase/ShowcaseTest.java
Outdated
Show resolved
Hide resolved
showcase/java/src/test/java/com/google/api/showcase/ShowcaseTest.java
Outdated
Show resolved
Hide resolved
Just spoke to dazuma and he said that naming collisions are definitely possible, real cases in cloud libs were worked around with synthtool, and were ultimately fixed with the microgenerator. I guess I should do something to exclude this proto from Ruby generation in this CI. |
Fixed it by breaking out ruby generation, and before generating it, I moved the offending proto out of the target directory and remove the service from the 1P yaml. Hacky, but really the only way to exclude this proto from ruby showcase gen. |
Codecov Report
@@ Coverage Diff @@
## master #3268 +/- ##
=========================================
Coverage 87.12% 87.12%
Complexity 6080 6080
=========================================
Files 494 494
Lines 24060 24060
Branches 2613 2613
=========================================
Hits 20962 20962
Misses 2236 2236
Partials 862 862 Continue to review full report at Codecov.
|
This updates the version of Showcase used for generation in CI to v0.12.0 and adds a test for the new SequenceService to assert the basic retry attempt logic and timeout-backoff behavior works as implemented.