Python: PR #2900 breaks system tests

[tseaver]

E.g., from this Kokoro job:

_ ERROR at setup of TestVisionClientVpcsc.test_batch_annotate_images_read_blocked _
    def setUpModule():
>       VisionSystemTestBase.client = vision.ImageAnnotatorClient()
tests/system.py:55:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
google/cloud/vision_v1/gapic/image_annotator_client.py:164: in __init__
    address=api_endpoint, channel=channel, credentials=credentials
google/cloud/vision_v1/gapic/transports/image_annotator_grpc_transport.py:70: in __init__
    "grpc.max_receive_message_length": -1,
google/cloud/vision_v1/gapic/transports/image_annotator_grpc_transport.py:109: in create_channel
    address, credentials=credentials, scopes=cls._OAUTH_SCOPES, **kwargs
../api_core/google/api_core/grpc_helpers.py:206: in create_channel
    return grpc.secure_channel(target, composite_credentials, **kwargs)
.nox/system-3-7/lib/python3.7/site-packages/grpc/__init__.py:1782: in secure_channel
    credentials._credentials, compression)
.nox/system-3-7/lib/python3.7/site-packages/grpc/_channel.py:1021: in __init__
    credentials)
src/python/grpcio/grpc/_cython/_cygrpc/channel.pyx.pxi:429: in grpc._cython.cygrpc.Channel.__cinit__
    ???
src/python/grpcio/grpc/_cython/_cygrpc/arguments.pyx.pxi:78: in grpc._cython.cygrpc._ChannelArgs.__cinit__
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>   ???
E   ValueError: too many values to unpack (expected 2)
src/python/grpcio/grpc/_cython/_cygrpc/arguments.pyx.pxi:37: ValueError
___ ERROR at setup of TestVisionClientVpcsc.test_import_product_sets_blocked ___
    def setUpModule():
>       VisionSystemTestBase.client = vision.ImageAnnotatorClient()
tests/system.py:55:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
google/cloud/vision_v1/gapic/image_annotator_client.py:164: in __init__
    address=api_endpoint, channel=channel, credentials=credentials
google/cloud/vision_v1/gapic/transports/image_annotator_grpc_transport.py:70: in __init__
    "grpc.max_receive_message_length": -1,
google/cloud/vision_v1/gapic/transports/image_annotator_grpc_transport.py:109: in create_channel
    address, credentials=credentials, scopes=cls._OAUTH_SCOPES, **kwargs
../api_core/google/api_core/grpc_helpers.py:206: in create_channel
    return grpc.secure_channel(target, composite_credentials, **kwargs)
.nox/system-3-7/lib/python3.7/site-packages/grpc/__init__.py:1782: in secure_channel
    credentials._credentials, compression)
.nox/system-3-7/lib/python3.7/site-packages/grpc/_channel.py:1021: in __init__
    credentials)
src/python/grpcio/grpc/_cython/_cygrpc/channel.pyx.pxi:429: in grpc._cython.cygrpc.Channel.__cinit__
    ???
src/python/grpcio/grpc/_cython/_cygrpc/arguments.pyx.pxi:78: in grpc._cython.cygrpc._ChannelArgs.__cinit__
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>   ???
E   ValueError: too many values to unpack (expected 2)

[noahdietz]

Does your suggestion in the PR fix things?

Sorry about this.

[busunkim96]

@noahdietz That should be it. For reference:

https://github.com/googleapis/google-cloud-python/blob/6f0df5dca4206f198789384a01940165659a3aff/logging/google/cloud/logging_v2/gapic/transports/logging_service_v2_grpc_transport.py#L65-L74

[tseaver]

@noahdietz

Does your suggestion in the PR fix things?

Yes, see the following where we've added that in synth.py: https://github.com/googleapis/google-cloud-python/blob/8c8e3606ecd214aafae4644d0ce6d4b293f32fa8/logging/synth.py#L41-L47

Sorry about this.

No worries

[noahdietz]

I will need to release this change via artman. CI will take some time but it will be released today.

[noahdietz]

Released in https://github.com/googleapis/artman/releases/tag/v0.32.1