-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporarily disable code coverage in showcase_unit tests #925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1703 +95
Branches 328 347 +19
=========================================
+ Hits 1608 1703 +95
Continue to review full report at Codecov.
|
Also updates version of showcase used
.github/workflows/tests.yaml
Outdated
cd /usr/src/showcase/ | ||
tar -xf showcase-* | ||
./gapic-showcase run & | ||
cd - | ||
env: | ||
SHOWCASE_VERSION: 0.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.16.0 too? Below as well.
Or I can do it when I rebase the pending #918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a deliberate attempted rollback to see if bumping the showcase version solved anything.
Also updates version of showcase used