Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix datetime comparison unit tests #898

Merged
merged 2 commits into from
May 20, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 19, 2021

Fixes #897

The string ident changed to have an _pb2 in #851. If there's a more robust way to do this comparison please let me know.

@busunkim96 busunkim96 requested a review from software-dov May 19, 2021 22:33
@busunkim96 busunkim96 requested a review from a team as a code owner May 19, 2021 22:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@busunkim96 busunkim96 requested a review from parthea May 19, 2021 22:33
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #898 (579af0a) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1697   +89     
  Branches       328       347   +19     
=========================================
+ Hits          1608      1697   +89     
Impacted Files Coverage Δ
gapic/samplegen_utils/types.py 100.00% <ø> (ø)
gapic/samplegen_utils/utils.py 100.00% <ø> (ø)
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb8c63...579af0a. Read the comment docs.

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 81932a2 into master May 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-datetime-comparisons branch May 20, 2021 14:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison fails for unit tests with timestamps
2 participants