Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic options flag to gapic script #66

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Dec 13, 2018

  • add --options to gapic.sh
  • add --python_gapic_opt=$PLUGIN_OPTIONS to Docker wrapper's protoc invocation

Note: ^ this requires an image build to take effect

Note: cross tested the script using an updated gapic-generator-go image, which worked

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         698    698           
  Branches      139    139           
=====================================
  Hits          698    698

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1b056...54251fd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         698    698           
  Branches      139    139           
=====================================
  Hits          698    698

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1b056...54251fd. Read the comment docs.

@lukesneeringer lukesneeringer merged commit c611366 into googleapis:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants