Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: improve coverage when generating clients with transport=rest #2241

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

tests: improve coverage when generating clients with transport=rest #2241

wants to merge 1 commit into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 30, 2024

This PR fixes the following coverage issue when generating showcase tests with transport=rest" instead of transport=grpc+rest

google/showcase_v1beta1/services/identity/transports/base.py            91      2     14      3    95%   87->92, 105, 116

With the changes in this PR, I see code coverage increase from 95% to 100%

google/showcase_v1beta1/services/echo/transports/base.py               104      0     10      0   100%

Towards #1926

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Oct 30, 2024
@parthea parthea force-pushed the improve-coverage-rest branch from acdb9af to a5a5680 Compare October 30, 2024 22:30
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 30, 2024
@parthea parthea marked this pull request as ready for review October 30, 2024 22:36
@parthea parthea requested a review from a team as a code owner October 30, 2024 22:36
@parthea parthea marked this pull request as draft November 14, 2024 16:49
@parthea parthea assigned parthea and unassigned vchudnov-g Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@parthea parthea

Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @vchudnov-g