fix: handle message bodies #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods with http annotations have body fields that are message types. Previously, generated unit tests did not handle this well. This is a fix for that: generate a reasonable mock value for the message, represented as a dict.
software-dov
requested review from
atulep,
busunkim96,
parthea and
vam-google
vam-google
approved these changes
Dec 30, 2021
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM. Just one question and please fix the tests before pushing.
| @@ -0,0 +1,53 @@ | |||
| // Copyright (C) 2021 Google LLC | |||
Contributor
There was a problem hiding this comment.
Is this file used? If yes, can you please explain how (I could not find any referrences to it from other parts of this PR
Contributor
Author
There was a problem hiding this comment.
It's used in the fragment tests. For each proto in this directory, we generate a GAPIC library and run its generated unit tests. This stresses both the templates and the actual logic of the generated surface. See noxfile.py:fragment for more detail on how the fragment tests work.
This particular fragment is the minimum required reproduction for the issues that compute was having.
Merged
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods with http annotations have body fields that are message types.
Previously, generated unit tests did not handle this well.
This is a fix for that: generate a reasonable mock value for the
message, represented as a dict.