fix: fix tests generation logic #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: 1) Fix test logic for grpc+rest case, when clients with both transports need to be initialized in parametrized tests 2) Fix 100% coverage problem for rest clients, when the http error (>= 400 error code) case logic was not covered.
google-cla
bot
added
the
cla: yes
kbandes
approved these changes
Oct 29, 2021
busunkim96
approved these changes
Oct 29, 2021
| {% endif %} | ||
| {% endfor %} | ||
| request = request_type(request_init) | ||
| {% if method.client_streaming %} |
There was a problem hiding this comment.
Is streaming supported for the rest transport?
There was a problem hiding this comment.
Not yet; that is intended to be part of next sprint. Currently it just raises NotImplemented.
software-dov
approved these changes
Oct 29, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
This should conclude the rest transport related fixes (for the time being at least)