Skip to content

Multiple syntax issues with latest generator release 0.44.0 #848

Closed
@parthea

Description

@parthea

There are various PRs opened by owl-bot that are failing for various syntax issues which we believe to be a result of the generator update. I'm going to use this issue to compile a list of the issues that I'm seeing.

For example,
python-area120-tables . See googleapis/python-area120-tables#36
The error is :

2021-04-27T03:52:51.581184531ZStep #5: error: cannot format /workspace/python-area120-tables/google/area120/tables_v1alpha1/types/tables.py: Cannot parse: 637:8: message=struct.Value,

There is a syntax error where there is a comma missing in the arguments for proto.MapField
See here.

class Row(proto.Message):
    r"""A single row in a table.
    Attributes:
        name (str):
            The resource name of the row. Row names have the form
            ``tables/{table}/rows/{row}``. The name is ignored when
            creating a row.
        values (Sequence[google.area120.tables_v1alpha1.types.Row.ValuesEntry]):
            The values of the row. This is a map of
            column key to value. Key is user entered
            name(default) or the internal column id based on
            the view in the request.
    """

    name = proto.Field(
        proto.STRING,
        number=1,
    )
    values = (
        proto.STRING,
        proto.MESSAGE,
        number=2 <---- comma missing here.
        message=struct.Value,
    )

The current client doesn't have a syntax error. See here.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions