Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paged requests do not use routing header metadata #469

Closed
busunkim96 opened this issue Jun 17, 2020 · 0 comments · Fixed by #470 or #1133
Closed

Paged requests do not use routing header metadata #469

busunkim96 opened this issue Jun 17, 2020 · 0 comments · Fixed by #470 or #1133
Assignees
@software-dov
Labels
conversion blocking A surface delta, bug, missing feature, or other issue that prevents API conversion priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

Currently blocking the KMS conversion.

For paged requests, the initial request includes the routing header but subsequent requests do not. Some APIs (KMS) appear to require the routing metadata on every request.
@busunkim96 busunkim96 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. conversion blocking A surface delta, bug, missing feature, or other issue that prevents API conversion labels Jun 17, 2020
@busunkim96 busunkim96 mentioned this issue Jun 17, 2020
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 22, 2020
software-dov pushed a commit that referenced this issue Jul 7, 2020
@busunkim96
fix: pass metadata to pagers (#470)
c43c6d9 
Closes #469
This was referenced Jan 18, 2022
Merged
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
conversion blocking A surface delta, bug, missing feature, or other issue that prevents API conversion priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@software-dov @busunkim96 @yoshi-automation