Skip to content

Commit

Permalink
[refactor] Remove docker pull from gapic.sh (#67)
Browse files Browse the repository at this point in the history
The `if` check did not work, but the functionality is unnecessary anyway (`docker run` will pull the image if it is not present).
  • Loading branch information
noahdietz authored and lukesneeringer committed Dec 17, 2018
1 parent c611366 commit f17766e
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions gapic.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,6 @@ if [ "$(ls -A $OUT )"]; then
>&2 echo "Warning: Output directory is not empty."
fi

# If the image is not yet on the machine, pull it.
if ! docker images $IMAGE > /dev/null; then
echo "Image $IMAGE not found; pulling."
if ! docker pull $IMAGE; then
exit $?
fi
fi

# Generate the client library.
docker run \
--mount type=bind,source=${PROTO_PATH}/${IN},destination=/in/${IN},readonly \
Expand Down

0 comments on commit f17766e

Please sign in to comment.