Skip to content

Commit

Permalink
fix: exclude 'input' from reserved names list (#788)
Browse files Browse the repository at this point in the history
The motivation for this is to prevent a breaking change in a library that has already been made GA: texttospeech googleapis/python-texttospeech#99. The TTS protos have a field named [`input`](https://github.com/googleapis/googleapis/blob/eabe7c0fde64b1451df6ea171b2009238b0df07c/google/cloud/texttospeech/v1/cloud_tts.proto#L134-L143).

Dialogflow CX beta appears to also have a field named `input`, but those changes have not yet been published and it is a pre-GA API.

https://github.com/search?l=Python&p=1&q=org%3Agoogleapis+input_&type=Code
  • Loading branch information
busunkim96 authored Feb 26, 2021
1 parent 2e17ede commit da2ff71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gapic/utils/reserved_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
RESERVED_NAMES = frozenset(
itertools.chain(
keyword.kwlist,
set(dir(builtins)) - {"filter", "map", "id", "property"},
set(dir(builtins)) - {"filter", "map", "id", "input", "property"},
)
)

0 comments on commit da2ff71

Please sign in to comment.