Skip to content

Commit

Permalink
fix: 'id' should not be a reserved name (#602)
Browse files Browse the repository at this point in the history
A number of python builtins collide with flattened fields from certain
API methods. More common names, especially ones that conflict with
builtins that aren't used by the surface, are explicitly allowed.
  • Loading branch information
software-dov authored Sep 17, 2020
1 parent 258762c commit c43c574
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gapic/utils/reserved_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
RESERVED_NAMES = frozenset(
itertools.chain(
keyword.kwlist,
set(dir(builtins)) - {"filter", "map"},
set(dir(builtins)) - {"filter", "map", "id"},
)
)

0 comments on commit c43c574

Please sign in to comment.