Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Application Default Credentials #62

Merged
merged 1 commit into from
Apr 1, 2021
Merged

feat: support Application Default Credentials #62

merged 1 commit into from
Apr 1, 2021

Conversation

tbpg
Copy link
Collaborator

@tbpg tbpg commented Apr 1, 2021

Fixes #60.

@tbpg tbpg requested a review from a team as a code owner April 1, 2021 17:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
busunkim96
busunkim96 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg merged commit 844b315 into master Apr 1, 2021
@tbpg tbpg deleted the adc branch April 1, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to use Application Default Credentials
2 participants
@tbpg @busunkim96