Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README with ADC credentials command #101

Merged
merged 2 commits into from
Apr 15, 2022
Merged

docs: update README with ADC credentials command #101

merged 2 commits into from
Apr 15, 2022

Conversation

dansaadati
Copy link
Contributor

No description provided.

@dansaadati dansaadati requested a review from a team April 14, 2022 19:51
@dansaadati dansaadati requested a review from a team as a code owner April 14, 2022 19:51
tbpg
tbpg approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One minor comment.

README.md Outdated Show resolved Hide resolved
@dansaadati @tbpg
Update README.md
cbe6cf6 
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
@tbpg tbpg changed the title fix: update README with ADC credentials command docs: update README with ADC credentials command Apr 15, 2022
@dansaadati dansaadati merged commit f515bbc into main Apr 15, 2022
@dansaadati dansaadati deleted the dansaadati-patch-1 branch April 15, 2022 15:54
@release-please release-please bot mentioned this pull request Apr 15, 2022
Merged
@tbpg
Copy link
Collaborator

tbpg commented Apr 15, 2022

Updated the title prefix to docs. A fix triggers a new release. See https://www.conventionalcommits.org/en/v1.0.0/#summary for a summary of the prefixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dansaadati @tbpg