Skip to content

feat(integration-tests): add test harness for cli invocation #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 26, 2025
Merged

feat(integration-tests): add test harness for cli invocation #1493

merged 9 commits into from
Jun 26, 2025

Conversation

@quirogas
Copy link
Contributor

@quirogas quirogas commented Jun 26, 2025 •
edited
Loading

Create TestMultipleFilesFromParentDir Integration Test

TestMultipleFilesFromParentDir emulates the issue described in #1465. This change ensures our integration test more robustly covers cases with nested package structures and proper import path resolution from the project root.

Directory structure

.
└── grandparent
    └── parent
        ├── a.proto
        └── b.proto

Command:

api-linter -I grandparent grandparent/parent/a.proto grandparent/parent/b.proto

@quirogas quirogas self-assigned this Jun 26, 2025
@quirogas quirogas changed the title Add test harness for cli invocation feat(integration-test): add test harness for cli invocation Jun 26, 2025
@quirogas quirogas changed the title feat(integration-test): add test harness for cli invocation feat(integration-tests): add test harness for cli invocation Jun 26, 2025
@quirogas quirogas requested a review from noahdietz June 26, 2025 18:26
noahdietz
noahdietz reviewed Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with all of the temp file stuff.

@quirogas quirogas marked this pull request as ready for review June 26, 2025 21:21
@quirogas quirogas requested a review from a team as a code owner June 26, 2025 21:21
@quirogas quirogas requested a review from noahdietz June 26, 2025 21:22
@quirogas
Copy link
Contributor Author

quirogas commented Jun 26, 2025

I think we should re-open #1465 too.

@noahdietz
Copy link
Collaborator

noahdietz commented Jun 26, 2025

I think we should re-open #1465 too.

Agreed

@quirogas
Copy link
Contributor Author

quirogas commented Jun 26, 2025

Skipping test for now, since the bug is still present.

noahdietz
noahdietz approved these changes Jun 26, 2025
View reviewed changes
@quirogas @noahdietz
Update cmd/api-linter/integration_test.go
b83f277 
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
@quirogas quirogas merged commit 35be28f into main Jun 26, 2025
8 checks passed
@quirogas quirogas deleted the add-test-harness-for-cli-invocation branch June 26, 2025 22:15
@release-please release-please bot mentioned this pull request Jun 26, 2025
Merged
@quirogas quirogas mentioned this pull request Jun 26, 2025
Closed
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2025
@release-please
chore(main): release 1.70.0 (#1494)
743dadf 
🤖 I have created a release *beep* *boop*
---


## [1.70.0](https://togithub.com/googleapis/api-linter/compare/v1.69.2...v1.70.0) (2025-07-16)


### Features

* **AIP-142:** add relative time segments comment rule ([5fab299](https://togithub.com/googleapis/api-linter/commit/5fab2997d1f81bf60b55c6ae6e3e3605212c9870))
* **AIP-142:** add time_offset type rule ([#1506](https://togithub.com/googleapis/api-linter/issues/1506)) ([945cff3](https://togithub.com/googleapis/api-linter/commit/945cff325fe38d4f8e3a7a620059a1e6b04c5107))
* **integration-tests:** add test harness for cli invocation ([#1493](https://togithub.com/googleapis/api-linter/issues/1493)) ([35be28f](https://togithub.com/googleapis/api-linter/commit/35be28f922581bff1f8ad6d2bb9289f6c57e2657))


### Bug Fixes

* **AIP-136:** support response msg lint with resource singular aligned field name ([#1499](https://togithub.com/googleapis/api-linter/issues/1499)) ([8dec010](https://togithub.com/googleapis/api-linter/commit/8dec01076c4bbeb0506c39610e325fc25bbda6ca))
* **AIP-158:** clarify pluralized response field finding ([#1498](https://togithub.com/googleapis/api-linter/issues/1498)) ([f0b7895](https://togithub.com/googleapis/api-linter/commit/f0b7895da8cd4b437ac0c3a9be2ac442560eeda8))
* **AIP-203:** field-behavior-required ignore imported request types ([#1504](https://togithub.com/googleapis/api-linter/issues/1504)) ([bb82f00](https://togithub.com/googleapis/api-linter/commit/bb82f006b37c85cf255ba8bddb1bf34a07993596)), refs [#1503](https://togithub.com/googleapis/api-linter/issues/1503)
* **cli:** unexpected lint warning when providing multiple files ([#1496](https://togithub.com/googleapis/api-linter/issues/1496)) ([7ecaa42](https://togithub.com/googleapis/api-linter/commit/7ecaa4200da7b5cbcbf1c273fc77d524f346ae1c)), refs [#1465](https://togithub.com/googleapis/api-linter/issues/1465)


### Documentation

* add comments to lint.Config and configuration page ([#1505](https://togithub.com/googleapis/api-linter/issues/1505)) ([39d0376](https://togithub.com/googleapis/api-linter/commit/39d0376281fb03f57b24efe0d82cb842e7316615))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees

@quirogas quirogas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quirogas @noahdietz