Skip to content

test: assert 3rd party reexports #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2024
Merged

test: assert 3rd party reexports #987

merged 1 commit into from
Dec 15, 2024

Conversation

c1825846
Copy link
Contributor

@c1825846 c1825846 commented Dec 14, 2024

Closes #979

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Collaborator

Hey, @c1825846,

Could you sign the CLA plz?

@c1825846 c1825846 changed the title test: assert 3rd party reexports\ncloses #979 test: assert 3rd party reexportscloses #979 Dec 15, 2024
@c1825846 c1825846 changed the title test: assert 3rd party reexportscloses #979 test: assert 3rd party reexports closes #979 Dec 15, 2024
@c1825846 c1825846 force-pushed the main branch 2 times, most recently from 8d0c46b to 3c72f4d Compare December 15, 2024 12:39
@c1825846
Copy link
Contributor Author

Hey, @c1825846,

Could you sign the CLA plz?

done

@c1825846 c1825846 changed the title test: assert 3rd party reexports closes #979 test: assert 3rd party reexports Dec 15, 2024
@antongolub antongolub added the ossln24 OSS Library Night 2024 label Dec 15, 2024
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c1825846 c1825846 requested a review from antongolub December 15, 2024 13:07
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted. Thanks for the contribution.

@antongolub antongolub merged commit 14ff473 into google:main Dec 15, 2024
21 checks passed
easymikey pushed a commit to easymikey/zx that referenced this pull request Dec 15, 2024
antongolub added a commit to antongolub/zx that referenced this pull request Dec 18, 2024
antongolub added a commit to antongolub/zx that referenced this pull request Dec 18, 2024
antongolub added a commit that referenced this pull request Dec 18, 2024
* test: merge autogenerated vendor tests

continues #987

* test: optimize test flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ossln24 OSS Library Night 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: assert 3rd party reexports
2 participants