Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let cwdHook be configurable #765

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

antongolub
Copy link
Collaborator

@antongolub antongolub commented Apr 2, 2024

process.cwd() // foo
$.cwdHook = false

within(async() => {
   cd('/bar')
   await sleep(10)
   await $`pwd` // now it is `/qux`, not `/bar`
})

cd('/qux')

relates #589

@antonmedv
Copy link
Collaborator

Let's rename to $.syncProcessCwd?

@antongolub
Copy link
Collaborator Author

antongolub commented Apr 2, 2024

$.cwdSyncHook ?
to provide more symmetry with $.cwd

@antonmedv antonmedv merged commit d79a638 into google:main Apr 2, 2024
12 checks passed
@antongolub antongolub deleted the cwd-hook-option branch April 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants