Skip to content

[pointer] Remove Ptr::project method #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Feb 13, 2025

Now that #1122 is complete in #1896, project is redundant.


This PR is on branch transmute-from.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (28b55b9) to head (347c999).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
- Coverage   89.34%   89.32%   -0.03%     
==========================================
  Files          16       16              
  Lines        6037     6025      -12     
==========================================
- Hits         5394     5382      -12     
  Misses        643      643              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the I15d38f2f1fffad82caa70ea6eb18dffcd6504495 branch from 34da5c7 to ed0cd83 Compare February 14, 2025 20:41
@joshlf joshlf force-pushed the Ia73ca4e5dfb3b20f71ed72ffda24dd7450c427ba branch 2 times, most recently from 07239f8 to 0f07add Compare February 14, 2025 23:34
@joshlf joshlf force-pushed the I15d38f2f1fffad82caa70ea6eb18dffcd6504495 branch from ed0cd83 to 2341b21 Compare February 14, 2025 23:34
@joshlf joshlf force-pushed the Ia73ca4e5dfb3b20f71ed72ffda24dd7450c427ba branch from 0f07add to 7655869 Compare February 14, 2025 23:42
@joshlf joshlf force-pushed the I15d38f2f1fffad82caa70ea6eb18dffcd6504495 branch from 2341b21 to 53cca63 Compare February 14, 2025 23:42
Base automatically changed from Ia73ca4e5dfb3b20f71ed72ffda24dd7450c427ba to main February 17, 2025 22:06
Now that #1122 is complete in #1896, `project` is redundant.

gherrit-pr-id: I15d38f2f1fffad82caa70ea6eb18dffcd6504495
@joshlf joshlf force-pushed the I15d38f2f1fffad82caa70ea6eb18dffcd6504495 branch from 53cca63 to 347c999 Compare February 17, 2025 22:07
@joshlf joshlf enabled auto-merge February 17, 2025 22:07
@joshlf joshlf added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 9322a2c Feb 17, 2025
69 checks passed
@joshlf joshlf deleted the I15d38f2f1fffad82caa70ea6eb18dffcd6504495 branch February 17, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants