Skip to content

Conversation

djkoloski
Copy link
Member

The large enums in zerocopy-derive's enum_from_bytes test make rust-analyzer hang during analysis. This change adds a VSCode config that allows us to hide that test from rust-analyzer. The test is still run as normal.

(split out from #879)

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (1336f4b) to head (0c8a162).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          15       15           
  Lines        5563     5563           
=======================================
  Hits         4879     4879           
  Misses        684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djkoloski djkoloski requested a review from joshlf July 16, 2024 20:23
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending one comment.

@djkoloski djkoloski force-pushed the add_vscode_ra_config branch from bf1f966 to f757dff Compare July 17, 2024 14:47
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but take a look at the comment and address it if possible. Feel free to merge without re-review.

@djkoloski djkoloski force-pushed the add_vscode_ra_config branch from f757dff to 0c8a162 Compare July 17, 2024 15:09
@djkoloski djkoloski added this pull request to the merge queue Jul 17, 2024
Merged via the queue into google:main with commit f660ff4 Jul 17, 2024
@djkoloski djkoloski deleted the add_vscode_ra_config branch July 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants