Improve pre-elaboration cycle detection error messages in XLS IR#3876
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Improve pre-elaboration cycle detection error messages in XLS IR#3876copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
The error message for cycle detection now includes the kind and name of the FunctionBase (function, proc, or block) where the cycle was found. It also provides more context and guidance on how to address the cycle, distinguishing between Blocks (suggesting a toolchain bug or register insertion) and Functions/Procs (suggesting a toolchain bug or error in IR construction). We also reverse the cycle path to be more intuitive, in (operand -> user) order. PiperOrigin-RevId: 874071831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve pre-elaboration cycle detection error messages in XLS IR
The error message for cycle detection now includes the kind and name of the FunctionBase (function, proc, or block) where the cycle was found. It also provides more context and guidance on how to address the cycle, distinguishing between Blocks (suggesting a toolchain bug or register insertion) and Functions/Procs (suggesting a toolchain bug or error in IR construction).
We also reverse the cycle path to be more intuitive, in (operand -> user) order.