[XLS] Add a more-precise model of OneHot for IntervalSets #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_761253861
branch
3 times, most recently
from
86f3083 to
095518f
Compare
Rather than converting our IntervalSets to ternary values, trying to model the impact of `one_hot` there, then converting back with poor resolution - we instead test if each possible result bit can be set, and add it to our resulting IntervalSet if it can. NOTE: The runtime performance of this should be `O(I*n^2)`, where `I` is the number of intervals in the input `val`, and `n` is `val.BitCount()`, since `CoversTernary` runs in `O(I*n)` time. PiperOrigin-RevId: 761588016
copybara-service
bot
force-pushed
the
test_761253861
branch
from
095518f to
4edd63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLS] Add a more-precise model of OneHot for IntervalSets
Rather than converting our IntervalSets to ternary values, trying to model the impact of
one_hotthere, then converting back with poor resolution - we instead test if each possible result bit can be set, and add it to our resulting IntervalSet if it can.NOTE: The runtime performance of this should be
O(I*n^2), whereIis the number of intervals in the inputval, andnisval.BitCount(), sinceCoversTernaryruns inO(I*n)time.