Log to stderr to match expected output shown in the "Hello, XLS!" tutorial #1745
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed. |
| ``` | ||
|
|
||
| You should see the following output: | ||
|
|
||
| ``` | ||
| [ RUN UNITTEST ] hello_test | ||
| trace of hello_string @ hello.x:4:17-4:31: [72, 101, 108, 108, 111, 44, 32, 88, 76, 83, 33] | ||
| ... trace of hello_string: [72, 101, 108, 108, 111, 44, 32, 88, 76, 83, 33] |
There was a problem hiding this comment.
Yes - I omitted the timestamp, thread ID, filename, and line number for brevity. The complete output looks something like this:
I1128 12:37:01.486118 1057 hello_xls.x:2] trace of hello_string: [72, 101, 108, 108, 111, 44, 32, 88, 76, 83, 33]
I suppose we could spell it all out in general terms:
IMMDD HH:MM:SS.MICROS THRDID hello_xls.x:2] trace of hello_string: [72, 101, 108, 108, 111, 44, 32, 88, 76, 83, 33]
Do you have a preference?
docs_src/tutorials/hello_xls.md
Outdated
| @@ -107,14 +107,14 @@ up! Open a terminal and execute the following in the XLS checkout root | |||
| directory: | |||
|
|
|||
| ``` | |||
| $ ./bazel-bin/xls/dslx/interpreter_main hello_xls.x | |||
| $ ./bazel-bin/xls/dslx/interpreter_main --logtostderr hello_xls.x | |||
When following the "Hello, XLS!" tutorial, I didn't see the expected output from running the hello_xls.x test. It looks like we need --logtostderr (or --alsologtostderr) for the output to match what is shown in the tutorial.