Fix typo in README.md install instructions #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix Chris! I think we should be python3 only so I think python3-dev is sufficient if you delete python-dev entirely I think it should all work. That looks like what the Dockerfile is doing -- "documentation needing to be kept in sync" problems because we can't have a dynamic README file. :-) |
The current version tells the user to install python3-dev twice. Remove one duplicate to match contents of Dockerfile.
|
Okay, SGTM. |
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 14, 2020
PiperOrigin-RevId: 337122924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version tells the user to install python3-dev twice.
I think the intention is to install both python-dev and python3-dev,
but there is a typo here.