Grab-bag of fixes for OS X #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebe
force-pushed
the
fixes
branch
2 times, most recently
from
f7c7075 to
ea72ae3
Compare
meheff
approved these changes
Aug 9, 2023
On GNU systems, strerror_r() returns char*, but on XSI systems it returns int. When checking the return value, we need to either compare with 0 or nullptr.
/bin/sh on OS X is very limited. Also, do some very minor cleanup.
On OS X, symbols are prepended with an underscore.
These have fixes for running on OS X.
hzeller
reviewed
Sep 5, 2023
| @@ -42,7 +42,7 @@ TEST(SubprocessTest, EmptyArgvFails) { | |||
|
|
|||
| TEST(SubprocessTest, NonZeroExitWorks) { | |||
| auto result = InvokeSubprocess( | |||
| {"/bin/sh", "-c", "echo -n hey && echo -n hello >&2 && exit 10"}, | |||
| {"/bin/bash", "-c", "echo -n hey && echo -n hello >&2 && exit 10"}, | |||
There was a problem hiding this comment.
While /bin/sh is pretty universally installed on Unix-like systems, /bin/bash is not (and so this test fails now on minimal Unix systems or where bash is in a different path).
What were the things that didn't work in OSX, could we re-work it to work with the minimal bourne shell available there ?
There was a problem hiding this comment.
The flags passed to echo weren't supported by /bin/sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.