New frontend web client #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new web client runner built from the ground up using rust and yew.rs. Part of #261 Right now web client must be manually built and launched separate to launching the backend. A followup PR will add a new flag to tell runner to use the new web client. Both the old and new client will be supported until the new front end has been thoroughly tested and has feature parity. --------- Co-authored-by: Julien Cretin <github@ia0.eu>
Co-authored-by: Julien Cretin <cretin@google.com>
…549) - Added CSS to match existing web client look. - Changed timeout on websockets to 1 second (1000 ms) - Also made the client reset and disable input when the websocket connection goes down. Should be the final bit that needs to be done to replace the old web client. --------- Co-authored-by: Julien Cretin <github@ia0.eu>
ia0
added
for:usability
ia0
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Thanks! I'll add @invernizzi to review the *.scss and *.html files and possibly do an end-to-end test too.
|
Hey @invernizzi , could you take a look at the cargo xtask applet rust hello runner host --no-default-features --web --log=info
cargo xtask applet rust button_abort runner host --no-default-features --web --log=info
cargo xtask applet rust panic runner host --no-default-features --web --log=info |
|
Actually, let me merge this because I'm going to do some changes that conflict, and the PR is good enough to merge, we can always address comments in follow-up PRs (like for the verbose logging). |
ia0
requested review from
invernizzi and
ia0-review
and removed request for
invernizzi
ia0-review
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Write the web client of the host runner in Rust #261