Add support for arbitrary shfmt command with arguments #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
suggested changes
Jun 7, 2020
Comment on lines
-85
to
+86
| The path to the shfmt executable. | ||
| The path to the shfmt executable. String, list, or callable that takes no args | ||
| and returns a string or a list. |
There was a problem hiding this comment.
Looks like you manually edited this without updating the source in flags.vim it's generated from, so it'll get reverted next time someone regenerates the help docs.
There was a problem hiding this comment.
I've updated the flags.vim and checked that vimdoc generates the same string. I've also updated flags.vim to have the source for the changes I've done manually in #124. I can split it into another PR if it's preferred.
There was a problem hiding this comment.
Thanks! Same PR is fine for this, no worries.
Make it possible to use complex shfmt commands, such as shfmt running in a docker container. Use the codefmt#formatterhelpers#ResolveFlagToArray approach seen in other formatters.
dbarnett
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to use complex shfmt commands, such as shfmt running in a docker container. Use the codefmt#formatterhelpers#ResolveFlagToArray approach seen in other formatters.
Similar to #124