fix: use jnp.exp(log_probs) instead of softmax(log_probs) in compute_entropy_from_logits#1387
Open
kuishou68 wants to merge 1 commit intogoogle:mainfrom
Open
fix: use jnp.exp(log_probs) instead of softmax(log_probs) in compute_entropy_from_logits#1387kuishou68 wants to merge 1 commit intogoogle:mainfrom
kuishou68 wants to merge 1 commit intogoogle:mainfrom
Conversation
…entropy_from_logits (Closes google#1386)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
compute_entropy_from_logitsintunix/rl/ppo/ppo_helpers.py.Closes #1386
Problem
Line 164 applies
jax.nn.softmax(log_probs)to convert log-probabilities to probabilities. This is mathematically incorrect:softmax(log_softmax(x))≠softmax(x)exp(log_softmax(x))=softmax(x)(i.e., the true probability distribution)Applying
softmaxto already log-normalized values produces a different distribution, leading to silently incorrect entropy values during PPO training.Fix
Replace
jax.nn.softmax(log_probs)withjnp.exp(log_probs)on line 164:Impact
The
compute_entropy_from_logitsfunction is called inppo_learner.pyto computetoken_entropy. The bug causes incorrect entropy values, which can silently affect PPO training metrics and dynamics.