-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about debugging with Docker #82
Conversation
Add common utils to docker image.
Hi @gaby, Thank you for your contribution! Although, I would prefer to keep the default container image as lightweight as possible. Maybe we could add some instructions in the README instead to help people debug these situations. Let me know your thoughts, otherwise I will close this PR after some time. ~tooryx |
@tooryx The problem is without some of those tools in the image you will need to build your own tsunami container for debugging. I could probably remove vi and iproute |
Could you not just inject yourself inside the container? $ docker run -d --rm --network="host" --name=tsunami -v "$(pwd)/logs":/usr/tsunami/logs frakman1/tsunami:latest --ip-v4-target=172.17.0.2
xxxxxxxx (the container id)
$ docker exec -it tsunami bash
# apt update && apt install -y vi {...} |
@tooryx Yes that will work as long as you have internet access. Adding a note to the readme should be enough. I will change the PR later today after work |
Thank you! |
@tooryx Done, I tried to keep simple and concise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gaby! I added a small note
@tooryx Done |
Tools were mentioned in #77